Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receipt logos: add support for black-and-white binary netpbm images. #282

Merged
merged 32 commits into from
May 9, 2024
Merged

Receipt logos: add support for black-and-white binary netpbm images. #282

merged 32 commits into from
May 9, 2024

Commits on May 4, 2024

  1. Receipt logos: initial draft implementation. 

      * Black-and-white PBM as only supported logo image format.
  * Logos stored in site config base64-encoded.
  * Some problems with vertical spacing of pixels are apparent.
  * Hacky triplication of horizontal pixels to achieve alignment during testing.
    @jayaddison
    jayaddison committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b2bb96a View commit details
    Browse the repository at this point in the history

  2. Dependencies: add 'imagesize' Python package dependency.

    @jayaddison
    jayaddison committed May 4, 2024
    Configuration menu
    Copy the full SHA
    bce2bdb View commit details
    Browse the repository at this point in the history

  3. Fix PBM image header parsing: 

      * Ignore comment lines during data extraction.
  * Use 'imagesize' library to retrieve width and height metadata.
    @jayaddison
    jayaddison committed May 4, 2024
    Configuration menu
    Copy the full SHA
    ea9bb87 View commit details
    Browse the repository at this point in the history

  4. Refactor / fixup: don't octuplicate the data.

    @jayaddison
    jayaddison committed May 4, 2024
    Configuration menu
    Copy the full SHA
    0dcc0cf View commit details
    Browse the repository at this point in the history

  5. Linting: fit within flake8-suggested line length limits.

    @jayaddison
    jayaddison committed May 4, 2024
    Configuration menu
    Copy the full SHA
    d72f0ee View commit details
    Browse the repository at this point in the history

  6. Fixup: assertion expectation should use an f-string for variable subs… 

    …titution.
    @jayaddison
    jayaddison committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c837eba View commit details
    Browse the repository at this point in the history

  7. Fixup: check for ASCII-encoded hash-symbol ('#') as bytestring, not u… 

    …nicode string.
    @jayaddison
    jayaddison committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5da27b9 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Cleanup: remove half-dot-feed command.

    @jayaddison
    jayaddison committed May 5, 2024
    Configuration menu
    Copy the full SHA
    3808a1e View commit details
    Browse the repository at this point in the history

  2. Fixup: re-use existing logic to correctly construct image width_info.

    @jayaddison
    jayaddison committed May 5, 2024
    Configuration menu
    Copy the full SHA
    1f26bde View commit details
    Browse the repository at this point in the history

  3. Refactor: rename 'bits' variable to 'line'.

    @jayaddison
    jayaddison committed May 5, 2024
    Configuration menu
    Copy the full SHA
    81de564 View commit details
    Browse the repository at this point in the history

  4. Fixup: include the padding bits when determining the bitimage command… 

    …'s width info.
    @jayaddison
    jayaddison committed May 5, 2024
    Configuration menu
    Copy the full SHA
    b09578a View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Refactor: use Python int.to_bytes function to prepare width_info data.

    @jayaddison
    jayaddison committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4ce2d19 View commit details
    Browse the repository at this point in the history

  2. Refactor: perform calculation of padding before row-partitioning the … 

    …image data.
    @jayaddison
    jayaddison committed May 6, 2024
    Configuration menu
    Copy the full SHA
    02b01a2 View commit details
    Browse the repository at this point in the history

  3. Refactor: rectify some variable names.

    @jayaddison
    jayaddison committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bf55022 View commit details
    Browse the repository at this point in the history

  4. Printing: group and transmit eight-line groups to the receipt printer.

    @jayaddison
    jayaddison committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a7e8902 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Padding: expand each pad-bit to a pad-byte.

    @jayaddison
    jayaddison committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9e335cc View commit details
    Browse the repository at this point in the history

  2. Revert "Padding: expand each pad-bit to a pad-byte." 

    This reverts commit 9e335cc.
    @jayaddison
    jayaddison committed May 7, 2024
    Configuration menu
    Copy the full SHA
    87eca3b View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Printing: use double-density horizontal printing, and read 24-bits of… 

    … vertical image for each output line.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6cca49c View commit details
    Browse the repository at this point in the history

  2. Fixup: include any incomplete 24-line chunk found at end of image dat… 

    …a during printing.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1f41665 View commit details
    Browse the repository at this point in the history

  3. Printing: set zero line-spacing for duration of image output, then re… 

    …store default line-spacing.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e5d8cbb View commit details
    Browse the repository at this point in the history

  4. Printing: process a carriage-return after each image line is printed.

    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2ffafaf View commit details
    Browse the repository at this point in the history

  5. Printing: add a carriage-return plus line-feed after each bitimage is… 

    … printed.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e55f5fa View commit details
    Browse the repository at this point in the history

  6. Fixup: append LF instead of CR after each row of image data.

    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    080c53c View commit details
    Browse the repository at this point in the history

  7. Refactor / cleanup: use [more_]itertools.batched to read up-to-24-lin… 

    …e ranges and up-to-8-bit column bitarrays.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    10b0a17 View commit details
    Browse the repository at this point in the history

  8. Config: correction for logo-config-existence check. 

    Co-authored-by: Stephen Early <[email protected]>
    @jayaddison @sde1000
    jayaddison and sde1000 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    71a8cb4 View commit details
    Browse the repository at this point in the history

  9. Refactor: use [more_]itertools.batched to read image data line-by-line.

    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    225edf6 View commit details
    Browse the repository at this point in the history

  10. Linting: declare long config description using shorter concatenated s… 

    …tring literals.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    46e97df View commit details
    Browse the repository at this point in the history

  11. Continuous integration: add newly-introduced dependencies. 

    Relates-to commits bce2bdb, 10b0a17.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6e086e7 View commit details
    Browse the repository at this point in the history

  12. Continuous integration: remove python3-more-itertools 

    Partially reverts commit 6e086e7.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    027b00b View commit details
    Browse the repository at this point in the history

  13. Refactor: use local implementation of iterable-chunking.

    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e4634c5 View commit details
    Browse the repository at this point in the history

  14. Dependencies: remove more-itertools dependency. 

    Partially-reverts commit 10b0a17.
    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d47cc3c View commit details
    Browse the repository at this point in the history

  15. Nitpick: cleanup: remove redundant iter(...) function call.

    @jayaddison
    jayaddison committed May 8, 2024
    Configuration menu
    Copy the full SHA
    136c5b9 View commit details
    Browse the repository at this point in the history