Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest fish users to install sdkman-for-fish #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

reitzig
Copy link

@reitzig reitzig commented Jul 14, 2018

Posting this as a discussion starter.

Goal: In order to make SDKMAN! accessible to fish, install sdkman-for-fish after the installation was otherwise successful (as an option).

  • Does not pester users without fish.
  • Does not pester users which already have an sdk.fish file. (Would conflict.)
  • Asks before installing.

Left to do: finish bash trickery; finalize wording.

Note:

  1. The installation method is opinionated.
  2. reitzig/sdkman-for-fish may have to mature a bit still.

Optionally, install sdkman-for-fish after installation was otherwise successful.

 * Does not pester users without fish.
 * Does not pester users which already have an `sdk.fish` file. (Would conflict.)
 * Asks before installing.

Left to do: finish bash trickery; finalize wording.

_Note:_ 
 1. The installation method is opinionated. 
 2. reitzig/sdkman-for-fish may have to mature a bit still.
@Markcial
Copy link

@reitzig I understand that you did that PR with the best of your intentions. But it won't simply work. That post-hook is intended to be run on bash (check on the shebang at the beginning of the line). And on bash, any of the commands or functions created for fish, won't be available.

captura de pantalla 2018-07-14 a las 16 26 42

@reitzig
Copy link
Author

reitzig commented Jul 15, 2018

Ugh, quite right. Juggling multiple shells for a day apparently got to me. :D Did I miss anything else? (Besides the unimplemented parts, those are intentional for now.)

@Markcial
Copy link

Good thinking. was busy at the moment and i failed to advice you to do what you have already solved. Sorry for that.

Also i left a couple of issues on your repository for sdkman

@reitzig
Copy link
Author

reitzig commented Nov 6, 2019

sdkman-for-fish has matured and I feel confident suggesting it to SDKMAN! users.

I updated the PR to propose a functional, skippable installation routine.

Concern: This makes the installer interactive. While the overlap between "uses fish" and "installs SDKMAN! in a non-interactive shell" is probably small, do we want to exclude it?
An alternative would be to just print the commands the user should execute.

Thoughts?

@reitzig reitzig changed the title Drafts a way to provide fish support Suggest fish users to install sdkman-for-fish Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants