Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#171] Updating gitignore to account for bin folder #175

Conversation

Eclipse-Dominator
Copy link
Contributor

Fixes #171

Previously, running the command ./gradlew generated a bin folder containing all the .class files.
To prevent accidentally committing files to the repository, let's adds /bin/ to the .gitignore file

@canihasreview
Copy link

canihasreview bot commented May 14, 2023

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

@Eclipse-Dominator Eclipse-Dominator force-pushed the 171-updating-gitignore-to-account-for-bin-folder branch 2 times, most recently from 778bcaa to 17dc864 Compare May 14, 2023 15:10
Running the command ./gradlew generated
a bin folder containing all the .class files.
To prevent accidentally committing files to the repository,
let's adds /bin/ to the .gitignore file
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023

Codecov Report

Merging #175 (17dc864) into master (1e05fef) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##             master     #175   +/-   ##
=========================================
  Coverage     72.15%   72.15%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1232     1232           
  Branches        125      125           
=========================================
  Hits            889      889           
  Misses          311      311           
  Partials         32       32           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@canihasreview
Copy link

canihasreview bot commented May 14, 2023

v1

@Eclipse-Dominator submitted v1 for review.

(📚 Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/175/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@damithc
Copy link
Contributor

damithc commented May 14, 2023

I could not reproduce this behavior on Windows i.e., I ran gradlew but it did not create a bin folder. 🤔

Commit message: generated -> generates?

@Eclipse-Dominator
Copy link
Contributor Author

After some investigation, the creation of bin/ folder seems to be caused by a separate vscode extension. As the focus of the module is the use of Intellij, let's close this for now.

@Eclipse-Dominator Eclipse-Dominator deleted the 171-updating-gitignore-to-account-for-bin-folder branch June 3, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating gitignore to account for bin folder
3 participants