[#162] Show warning when ignoring repeated parameters #176
Conversation
Repeated occurrences of the same parameter in a command are being ignored without any notification to the user. This can lead to potential user errors going unnoticed, especially when using the wrong parameter prefix multiple times. Let's introduces a warning system that alerts the user when a parameter is being ignored. Now, if a parameter is repeated in a command, a warning message will be displayed to ensure that the user is aware of any unintentional mistakes or typos.
|
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
v1@Eclipse-Dominator submitted v1 for review. Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/176/1/head:BRANCHNAMEwhere |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #176 +/- ##
============================================
- Coverage 72.15% 71.93% -0.23%
- Complexity 399 402 +3
============================================
Files 70 70
Lines 1232 1247 +15
Branches 125 131 +6
============================================
+ Hits 889 897 +8
- Misses 311 312 +1
- Partials 32 38 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eclipse-Dominator
changed the title
There was a problem hiding this comment.
I'm a bit hesitant about this approach because,
- It doesn't inform the user which parameter is duplicated
- It doesn't differentiate between one parameter being duplicated vs multiple parameters being duplicated
Perhaps we should explore alternatives to see if there is a better way?
| @@ -49,6 +49,8 @@ public class EditCommand extends Command { | |||
| public static final String MESSAGE_EDIT_PERSON_SUCCESS = "Edited Person: %1$s"; | |||
| public static final String MESSAGE_NOT_EDITED = "At least one field to edit must be provided."; | |||
| public static final String MESSAGE_DUPLICATE_PERSON = "This person already exists in the address book."; | |||
| public static final String MESSAGE_DUPLICATE_FIELD = "Detected multiple modification to a same parameter, " | |||
| + "applying the latest change.\n"; | |||
There was a problem hiding this comment.
modification -> modifications?
Is it correct to say modifications i.e., are these strictly modifications or something else? Similarly, 'latest change' doesn't seem like the correct phrase.
|
Hmm, alright, I chose this initially as I felt this will require the least amount of changes but I will come up with a secondary approach to display which field has been duplicated. |
Yup, this may still be the best option but it's better to explore other options before making a decision. |
|
I have created a secondary PR to show an alternative approach in #181 |
|
Closing in favor of #190 |
Eclipse-Dominator
deleted the
162-give-a-warning-when-a-parameter-is-repeated-in-a-user-command
branch
Fixes #162
Currently, repeated occurrences of the same parameter in a command are being ignored without any notification to the user. This can lead to potential user errors going unnoticed, especially when using the wrong parameter prefix multiple times.
This commit introduces a friendly warning system that alerts the user when a parameter is being ignored. Now, if a parameter is repeated in a command, all occurrences except the last one will trigger a warning message, ensuring that the user is aware of any unintentional mistakes or typos.
Let's provide a better user experience by catching and notifying them of ignored parameters, improving the overall usability and preventing potential errors.