[#166] Bump javafx to version 11.0.2

[Eclipse-Dominator]

Fixes #166

Conflict between JavaFx version 11 and Ubuntu 18.04 and above described in JDK-8210411 presents a compatibility issue for users using Ubuntu 18.04 and above. This fatal crash also causes JVM to generate a hs_err_pid log file.

This issue is fixed in JavaFx version 11.0.2. Let's bump JavaFx to the appropriate version to avoid this issue.

[canihasreview]

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

[canihasreview]

v1

@Eclipse-Dominator submitted v1 for review.

• [v1 1/2] Fix JavaFx compatibility issue
• [v1 2/2] Add hs_err_pid log files to .gitignore

(📚 Archive)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/177/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

[damithc]

Commit 1:
The commit message (subject or body) does not specify what is the actual issue being fixed.
Include a brief description. In addition, if there is an online description of the problem, we can give a link.
described in JDK-8210411 presents a compatibility issue for users using is longer than 72 chars.

Commit 2:
Let's not sneak in unrelated changes into a PR. That reduces the searchability of the PR/issue tracker.

[canihasreview]

v2

@Eclipse-Dominator submitted v2 for review.

• [v2 1/1] Fix JavaFx compatibility issue

(📚 Archive) (📈 Interdiff between v1 and v2) (📈 Range-Diff between v1 and v2)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/177/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

[codecov-commenter]

Codecov Report

Merging #177 (b7a2713) into master (481a3d9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #177   +/-   ##
=========================================
  Coverage     72.06%   72.06%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1235     1235           
  Branches        127      127           
=========================================
  Hits            890      890           
  Misses          314      314           
  Partials         31       31           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[damithc]

I assume you tested this to confirm the fix works (I didn't).

Separately, check our JavaFX guide (https://se-education.org/guides/tutorials/javaFx.html) and the Grade guide to see if they need updating too.

Commit message subject is too generic?

[damithc]

@zhongfu I remember you did some investigation into this problem earlier. If you are free, your inputs are welcome.

[zhongfu]

Looks good to me; I can confirm that this PR allows AB3 to run on Wayland without needing to force the use of X11 explicitly

(p.s. sorry for the late reply -- I missed this somehow)

[damithc]

@zhongfu thanks very much for checking. 👍

[canihasreview]

v3

@Eclipse-Dominator submitted v3 for review.

• [v3 1/1] Fix JavaFx crashing in some linux distributions

(📚 Archive) (📈 Interdiff between v2 and v3) (📈 Range-Diff between v2 and v3)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/177/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.