-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#182] Local github page deployment fails on Ruby >=3.0 #185
[#182] Local github page deployment fails on Ruby >=3.0 #185
Conversation
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
e275d14
to
20e1834
Compare
v1@Eclipse-Dominator submitted v1 for review. Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/185/1/head:BRANCHNAME where |
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage 72.06% 72.06%
Complexity 399 399
=========================================
Files 70 70
Lines 1235 1235
Branches 127 127
=========================================
Hits 890 890
Misses 314 314
Partials 31 31 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, but I am not very familiar with Ruby or Jekyll. Let's leave it here for a few days in case others have any comments.
Commit message:
- Try to make the commit subject more specific so that it tell us what exact problem was fixed.
- The local testing is nothing to do with GitHub Pages. It's just a Jekyll server.
Running `bundle exec jekyll serve` to start a Jekyll server to serve the application's documentation page will crash due to a compatibility issue with Jekyll 3 and Ruby >=3.0. Let's resolve this by - adding "webrick" to Gemfile - updating the relevant packages
20e1834
to
b2d03aa
Compare
v2@Eclipse-Dominator submitted v2 for review. (📚 Archive) (📈 Interdiff between v1 and v2) (📈 Range-Diff between v1 and v2) Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level3.git refs/pr/185/2/head:BRANCHNAME where |
No further comments on the fix but a couple of questions, mostly out of curiosity.
|
I think prior to ruby 3.0, "webricks" package is installed by default. That's why after ruby 3.0, jekyll server will fail since they can no longer find the webricks package. I think those were the version numbers after I updated ruby packages. I think I can fine tune the versions more? Alternatively, just removing gem.lock file and let the users install the latest version will work as well |
I have no further comments on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on my end and LGTM! I think it is better to keep the gem.lock file just in case the newer versions of the gems installed by bundler causes the website to crash.
Thanks for the fix @Eclipse-Dominator |
Fixes #182
Running
bundle exec jekyll serve
to test GitHub page deployment will fail due to a compatibility issue with Jekyll 3 and Ruby >=3.0.Let's resolve this by