Bug fixes and readability improvements to guest memory handling#103
Open
hlyytine wants to merge 4 commits intoseL4:masterfrom
Open
Bug fixes and readability improvements to guest memory handling#103hlyytine wants to merge 4 commits intoseL4:masterfrom
hlyytine wants to merge 4 commits intoseL4:masterfrom
Conversation
Comment in vm_map_reservation() about resetting the iterator was only partially true. Return value did not report any errors either. Also avoid integer overflows and fix a format string. Signed-off-by: Hannu Lyytinen <hannux@ssrc.tii.ae>
Signed-off-by: Hannu Lyytinen <hannux@ssrc.tii.ae>
LH side of comparison in vm_memory_handle_fault() uses wrong value. Avoid potential overflows in other places as well. Signed-off-by: Hannu Lyytinen <hannux@ssrc.tii.ae>
Signed-off-by: Hannu Lyytinen <hannux@ssrc.tii.ae>
hlyytine
force-pushed
the
upstream/guestmem-fixes
branch
from
7aa142b to
f58d054
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_vm_memory_reservation()As far as I can see, the only potential side effect of these changes is that mapping done by
map_vm_memory_reservation()is no longer allowed to overflow the region. But I can't think of situation where that could anything else than a bug.