Skip to content

Extend maintenance to handle multiple LRs at a time #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JorgeMVP wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extend maintenance to handle multiple LRs at a time #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52af70e
maintenance irq: EISR to decode LR id
JorgeMVP May 28, 2023
94ff5e8
maintenance irq: support handling multiple LRs
JorgeMVP May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions libsel4vm/src/arch/arm/vgic/vgic_v2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,18 +276,23 @@ int vm_install_vgic(vm_t *vm)

int vm_vgic_maintenance_handler(vm_vcpu_t *vcpu)
{
int idx = seL4_GetMR(seL4_VGICMaintenance_IDX);
/* Currently not handling spurious IRQs */
assert(idx >= 0);

int err = handle_vgic_maintenance(vcpu, idx);
if (!err) {
seL4_MessageInfo_t reply;
reply = seL4_MessageInfo_new(0, 0, 0, 0);
seL4_Reply(reply);
} else {
ZF_LOGF("vGIC maintenance handler failed (error %d)", err);
uint64_t eisr = seL4_GetMR(seL4_VGICMaintenance_EISR1);
eisr <<= 32;
eisr |= seL4_GetMR(seL4_VGICMaintenance_EISR0);

while (eisr) {
int idx = __builtin_ctzll(eisr);
int err = handle_vgic_maintenance(vcpu, idx);
if (err) {
ZF_LOGF("vGIC maintenance handler failed (error %d)", err);
}
eisr &= ~(1ULL << idx);
}

seL4_MessageInfo_t reply;
reply = seL4_MessageInfo_new(0, 0, 0, 0);
seL4_Reply(reply);

return VM_EXIT_HANDLED;
}

Expand Down