Open
Conversation
axel-h
force-pushed
the
patch-axel-17
branch
3 times, most recently
from
f7c9056 to
d09e92b
Compare
added 4 commits
July 15, 2022 01:10
This is a preparation for GICv3 support, where this function becomes more complex. Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
This is a preparation for GICv3 support, where this function becomes more complex. Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Drop the explicit vm parameter, as it is not used. It can be obtained from the vcpu context if necessary. Pass the vgic parameter first to align with the other functions. Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
axel-h
force-pushed
the
patch-axel-17
branch
3 times, most recently
from
b6560ee to
46dcf45
Compare
added 5 commits
July 15, 2022 03:41
Also make error message more specific. Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Passing vgic allows hiding the actual type of vgic->dist from the function signature, so the GICv2 and GICv3 types are handed silently by the compiler. Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
struct vgic_dist_deviceand store data instruct vgic.This is on top of #70 and part of a branch that adds GICv3 support with Hensoldt-Cyber#1