✨ feat(windows): add safe one-click CPA launcher - #378
✨ feat(windows): add safe one-click CPA launcher#378systemoutprintlnhelloworld wants to merge 1 commit into
Conversation
Start CPA and Manager Plus together with validated process ownership, end-to-end readiness checks, current-user shortcuts, and packaged Windows scripts.
|
Thanks for continuing to improve the Windows launcher and for adding more complete process management, rollback, and readiness handling. After reviewing the implementation and the current project roadmap, I have decided not to merge this PR. The project already has an active development branch that integrates CPA and CPAMP through a dedicated runtime scheduler. That branch is intended to become the central place for managing both services, including startup order, shutdown, process state, health checks, recovery, and runtime coordination. This PR implements many of those same responsibilities independently in PowerShell. Merging it would create two parallel lifecycle-management systems: the runtime scheduler and the Windows launcher. Maintaining both would increase complexity, make behavior dependent on which entry point the user chooses, and create ongoing synchronization work whenever process handling, configuration, ports, or health checks change. There are also implementation details that would require further redesign, but the main issue is architectural rather than a collection of isolated bugs. Even if those individual issues were fixed, this launcher would still overlap with the runtime-based solution that is already under development. For that reason, I do not think continuing to revise this PR would be the best use of effort. I am going to close it in favor of completing the unified CPA + CPAMP runtime implementation. Thank you for the substantial work put into this proposal. |
Summary
%*forwarding, logs, cross-process locking, rollback, release packaging, and documentationTest plan
go test ./internal/http/controller/health ./internal/http/routergo build ./cmd/cpa-manager-plusbin/native/cpa-launcher.ps1with the PowerShell AST parsercpa-launcher.ps1 status -NoPausegit diff --checkgo test ./...on Windows: all relevant packages pass, but the existinginternal/securitytest expects POSIX mode0600and observes0666on Windows