fix(web): prevent drawer close on text drag#440
Merged
Conversation
Only close the drawer when pointer down and up both land on the overlay itself. Stops accidental close when users drag-select text from inputs onto the mask. Covers provider edit drawers and other Drawer consumers.
Track overlay pointer presses by pointerId so multi-touch interleaving cannot close the drawer incorrectly. Also unmount renderers and restore DOM globals between tests.
Use () => void for mountDrawer's onClose parameter so tsc accepts vi.fn() mocks against DrawerProps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Drawer overlay false close when users drag-select text from inputs onto the mask. Only close when pointer down and up both land on the overlay itself, and add unit coverage for the three press/release paths.
Scope
Changes
onClickclose with pointer down/up pairingUser Impact
Provider edit drawers and other Drawer consumers no longer close accidentally when users drag-select text from inputs onto the overlay. Intentional overlay click-to-close still works.
Compatibility / Runtime Notes
Data / Security Notes
N/A — no SQLite, credential, auth file, log, raw usage data, or plugin changes.
Risk / Rollback
Risk level: Low
Rollback notes:
onClickclose behaviorVerification
Commands / evidence:
Screenshots / Recordings
N/A — interaction fix only; no visual layout change. Recommended manual check:
Docs
Docs decision:
Bugfix for existing Drawer close interaction; no new capability, config surface, or docs path change.
Related
Closes #437