fix(manager-server): drop priced models from sync feedback - #457
Open
Lxcardoza993 wants to merge 1 commit into
Open
fix(manager-server): drop priced models from sync feedback#457Lxcardoza993 wants to merge 1 commit into
Lxcardoza993 wants to merge 1 commit into
Conversation
Owner
|
Thanks for addressing the mismatch between the sync notification and the rows that are actually actionable on the Model Prices page. The implementation applies cleanly on the latest
It would also be helpful to add a Please also confirm that narrowing the API response is intentional: after a saved price is deleted, previously filtered candidate information will not reappear until another sync. Recommendation: merge after the required template and CI issues are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync no longer reports pending-candidate or unmatched entries for models that
already have a stored price, so the notification counts match what the model
prices page can actually act on.
Scope
Changes
candidatesandunmatchedinService.Syncagainst the storedprice table before returning the sync result (reuses the already-loaded
price map; no extra queries).
User Impact
The "Sync complete: imported X, pending Y, unmatched Z" notification now only
counts models without a stored price — the same set shown under the "Pending"
filter on the model prices page. Previously, already-priced models (e.g.
manually configured custom models) were counted as pending on every sync while
the UI intentionally hides them to protect manual prices, so the notification
permanently reported actionable-looking counts with no matching rows.
Compatibility / Runtime Notes
candidates/unmatchednow only includemodels without a stored price.
matched,imported,skipped, and priceupsert behavior are unchanged.
Data / Security Notes
N/A — no schema, key, or stored-data changes; the filter reuses the price map
already loaded by
Service.Sync.Risk / Rollback
Low. Response-only filtering; no persistence changes. Revert restores the
previous counts.