fix: allow generating GET and POST openapi spec#159
Merged
Conversation
github-actions bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
## [2.17.3](v2.17.2...v2.17.3) (2025-06-18) ### Bug Fixes * allow generating GET and POST openapi spec ([#159](#159)) ([f0a61a8](f0a61a8))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Pretty much the title, previously generating the OpenAPI json would ignore GET if POST was defined as well. Now it generates both (and DELETE too).
Main change was to remove the filter at https://github.com/seamapi/nextlove/pull/159/files#diff-3f2c0f6d81a28b504bad9f4790e395fdf0d3fd6dd3fe8848371b3499e243abd1L179
But because request body and query definitions were checked at the route level and not the method level, this resulted in the generated spec to be wrong. i.e. generating a
requestBodyfor GET and not aparameters.The fix was to create a loop per method, and move the body and query defs in there instead. Looks like lots of changes, but it's just moving nesting: https://github.com/seamapi/nextlove/pull/159/files#diff-3f2c0f6d81a28b504bad9f4790e395fdf0d3fd6dd3fe8848371b3499e243abd1R213
This test asserts that each generated method looks right