Conversation
| override: true | ||
|
|
||
| - name: Test | ||
| run: MIRIFLAGS="-Zmiri-tag-raw-pointers -Zmiri-check-number-validity" cargo miri test |
There was a problem hiding this comment.
I assume you'll know best: what's the likelihood of these changing and causing our CI to fail?
There was a problem hiding this comment.
These flags basically put Miri into "hard mode", adding some extra checks that are off-by-default but give extra confidence in the unsafe code. I'm not sure what kind of unsafe code httparse uses or which kind of code you plan to use in the future, so I cannot really give failure probabilities for the UB checks.
When we change flags we usually first just deprecate them (showing a warning) because we know removing them would break CI. Even this happens rarely. The last actual breaking change wrt our flags was rust-lang/miri#1769; back then I made an effort to send PRs or at least "heads-up" issues to all projects I could find that used Miri on CI to fix them preemptively. I don't even remember the last breaking flag change before that...
2 participants
This only works if we use the fallback implementation with Miri.
(FWIW, using
core::simdwould work, butcore::archsimply has too many intrinsics to support them all in Miri.)