Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParserConfig accessors, convenience methods, and request parsing options #159

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tgnottingham
Copy link

Add missing ParserConfig accessors, convenience methods for configuring request and response parsing simultaneously, and request parsing options that bring request parsing configuration up to parity with response parsing configuration.

@tgnottingham
Copy link
Author

Hi @seanmonstar, sorry to ping, but do you think there are any deal-breakers with the concept of this PR? The purpose was mainly to add parsing options that were present for responses but missing for requests (allow_spaces_after_header_name_in_requests and allow_obsolete_multiline_headers_in_requests).

I could see the addition of the methods that configure request parsing and response parsing simultaneously being undesirable, for example, and I can remove if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant