Conversation
|
Changes Unknown when pulling 3c366e9 on upgrades into ** on master**. |
|
Changes Unknown when pulling 5c6ebab on upgrades into ** on master**. |
|
Changes Unknown when pulling 6ee181e on upgrades into ** on master**. |
|
Changes Unknown when pulling b2cc7ac on upgrades into ** on master**. |
|
Changes Unknown when pulling 22ae28f on upgrades into ** on master**. |
|
Changes Unknown when pulling 3848461 on upgrades into ** on master**. |
chrisvoll
left a comment
chrisvoll
left a comment
There was a problem hiding this comment.
I left a couple comments, but these changes look great! Nice to see cypress used in production too
| }).toThrow(); | ||
| } | ||
| // expect(rootNode.topSpacer._style._values.height).toEqual('400px'); | ||
| // expect(rootNode.bottomSpacer._style._values.height).toEqual('1600px'); |
There was a problem hiding this comment.
Please remove these commented out tests if they're no longer relevant :)
| </Infinite> | ||
| ); | ||
|
|
||
| expect(rootNode).toMatchSnapshot(); |
There was a problem hiding this comment.
I'm not so sure that a snapshot does a better job of capturing this than explicitly looking for pointer-events being undefined. The test's description is much more specific than the test itself
| waitsFor(function() { | ||
| return infiniteSpy.callCount > 0; | ||
| }); | ||
| const infiniteSpy = jasmine.createSpy('infiniteSpy'); |
There was a problem hiding this comment.
jasmine APIs are no longer officially supported within jest, so for future compatibility these should be replaced with jest.fn()
| @@ -0,0 +1,22 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
Which eslint rules does this break? If it's just the cy variable, you could drop a .eslintrc config in the cypress directory with cy as a global
| cy.get("#infinite-example-one").as('basic'); | ||
|
|
||
| // Shows only | ||
| for (var i = 0; i < 8; i++) { |
|
Changes Unknown when pulling 9549cd3 on upgrades into ** on master**. |
|
Changes Unknown when pulling 1596a17 on upgrades into ** on master**. |
3 participants
createClassto ES2015 classprettierand upgradeseslintjestto version 20 and updates to snapshot testsflowto version 0.52 and updates typesnode_modulesinfiniteLoadBeginBottomOffset, deprecated since 0.6.0Moving to Webpack 2 and ES2015
importswill likely be done in a future pull request.