Remove support for metadata in doc-comments #5714
Draft
+45
−4,725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann
added
type/backward-compatibility
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5714 +/- ##
============================================
- Coverage 94.03% 93.99% -0.04%
+ Complexity 6590 6375 -215
============================================
Files 700 691 -9
Lines 19884 19272 -612
============================================
- Hits 18697 18114 -583
+ Misses 1187 1158 -29 ☔ View full report in Codecov by Sentry. |
sebastianbergmann
force-pushed
the
phpunit-12/annotations-cleanup
branch
5 times, most recently
from
e817f3d
to
72c3d3c
Compare
sebastianbergmann
force-pushed
the
phpunit-12/annotations-cleanup
branch
from
72c3d3c
to
3bcf8b9
Compare
sebastianbergmann
force-pushed
the
phpunit-12/annotations-cleanup
branch
from
5649afa
to
245c5fb
Compare
sebastianbergmann
force-pushed
the
phpunit-12/annotations-cleanup
branch
from
79c0053
to
daf9289
Compare
sebastianbergmann
force-pushed
the
phpunit-12/annotations-cleanup
branch
2 times, most recently
from
393e083
to
8d8016e
Compare
…ted by the annotation parser
sebastianbergmann
force-pushed
the
phpunit-12/annotations-cleanup
branch
from
8d8016e
to
a6cbf91
Compare
|
from a contributor perspective getting rid of the "duplicated metadata stuff" is a really welcome change. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5541.