Stop shutdown handler outputting in child processes #6411
Conversation
|
@staabm Can you have a look at this? Thanks! |
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "ext-pcntl": "*" | ||
| }, |
There was a problem hiding this comment.
composer.lock needs to be updated after composer.json is changed. This is the reason why the CI pipeline failed.
| @@ -0,0 +1,23 @@ | |||
| --TEST-- | |||
| ShutdownHandler does not output when child process exits | |||
| --FILE-- | |||
There was a problem hiding this comment.
This needs a --SKIPIF-- section to skip the test when the pcntl extension is not available.
There was a problem hiding this comment.
Also note that we might not set up PHP with the pcntl extension in our CI pipeline yet.
There was a problem hiding this comment.
Also note that we might not set up PHP with the
pcntlextension in our CI pipeline yet.
we need this change in earlier release branches. therefore I am doing it here: #6412
| @@ -0,0 +1,23 @@ | |||
| --TEST-- | |||
| ShutdownHandler does not output when child process exits | |||
| --FILE-- | |||
There was a problem hiding this comment.
needs a SKIPIF whether pcntl extension is available
composer.json
Outdated
| "require-dev": { | ||
| "ext-pcntl": "*" | ||
| }, |
There was a problem hiding this comment.
I don't think we need this change, because we need pcntl only for this single test but not for general development of phpunit.
getmypid() seems available even without pcntl.
we already have other tests depending on pcntl without this setting
There was a problem hiding this comment.
OK, done. Yes, getmypid() is part of the core.
| $_SERVER['argv'][] = '--filter'; | ||
| $_SERVER['argv'][] = 'testChildProcessOutput'; |
There was a problem hiding this comment.
we can drop the --filter testChildProcessOutput - it's unnecessary
3 participants
This fixes #6410