Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update express 4.18.3 β†’ 4.19.2 (minor) #250

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 25, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ express (4.18.3 β†’ 4.19.2) Β· Repo Β· Changelog

Security Advisories 🚨

🚨 Express.js Open Redirect in malformed URLs

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

0867302
0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

#5539
koajs/koa#1800
https://expressjs.com/en/4x/api.html#res.location

Release Notes

4.19.2

What's Changed

Full Changelog: 4.19.1...4.19.2

4.19.0

What's Changed

New Contributors

Full Changelog: 4.18.3...4.19.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 13 commits:

↗️ cookie (indirect, 0.5.0 β†’ 0.6.0) Β· Repo Β· Changelog

Release Notes

0.6.0 (from changelog)

  • Add partitioned option

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 33 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the dependencies Pull requests that update a dependency file label Mar 25, 2024
@depfu depfu bot merged commit 7e91dcb into develop Mar 25, 2024
9 checks passed
@depfu depfu bot deleted the depfu/update/npm/express-4.19.2 branch March 25, 2024 20:15
@sebbo2002
Copy link
Owner

πŸŽ‰ This PR is included in version 5.1.1-develop.12 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@sebbo2002
Copy link
Owner

πŸŽ‰ This PR is included in version 5.1.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released on @next released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant