Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip the automotive_comm tests on Packit for now #4562

Closed
wants to merge 1 commit into from

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Oct 7, 2024

python3-can can't be installed on Rawhide due to
https://bugzilla.redhat.com/show_bug.cgi?id=2315547.

I'll convert it to draft because another option would be to remove Rawhide from the packit config here and keep it in my fork. This way the CI should be less flaky here and it should still be possible for me to catch things popping up when the latest versions of its test/runtime dependencies are rolled out on Rawhide. The testing strategy is being discussed in packit/packit#2407 (reply in thread) so I'll try to figure out what would be better.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.61%. Comparing base (93c9472) to head (2bcee63).
Report is 31 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4562   +/-   ##
=======================================
  Coverage   81.61%   81.61%           
=======================================
  Files         356      356           
  Lines       85544    85544           
=======================================
+ Hits        69818    69819    +1     
+ Misses      15726    15725    -1     

see 4 files with indirect coverage changes

@evverx evverx marked this pull request as draft October 8, 2024 00:59
@evverx
Copy link
Contributor Author

evverx commented Jan 4, 2025

https://bugzilla.redhat.com/show_bug.cgi?id=2315547 was closed recently and to judge from https://download.copr.fedorainfracloud.org/results/packit/evverx-scapy-2/fedora-rawhide-aarch64/08469912-scapy/builder-live.log.gz this patch is no longer needed.

I think all in all it would maybe make sense to keep manual_trigger for the time being. (Though as far as I understand the Packit folks are OK with triggering it automatically).

@evverx evverx closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant