Async Inventory Loading Implementation #4893
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- various improvements - lazily creates the UI wigets for categories when their parent is expanded
Allow builds to be manually triggered
Ansariel
reviewed
Oct 24, 2025
Ansariel
reviewed
Oct 24, 2025
akleshchev
reviewed
Oct 24, 2025
akleshchev
reviewed
Oct 24, 2025
| // If we run out of time, this still should create root folders | ||
| buildNewViews(gInventory.getRootFolderID()); // My Inventory | ||
| buildNewViews(gInventory.getLibraryRootFolderID()); // Library | ||
| // Build only root widgets - children will load on-demand when expanded |
Contributor
There was a problem hiding this comment.
Loading 'on demand' potentilly breaks search (assuming it's permanent and not 'on demand untill something in the background eventually gets to it'.
Things to test:
- Recent tab should show recent items since last logoff
- Favorites tab should populate
- Create an item, assign a texture, relog, confirm texture was selected in picker.
marchcat
added a commit
that referenced
this pull request
Oct 29, 2025
- store cache keys as std::string to avoid dangling references - refresh parent entry on rename and skip unnamed views
- store cache keys as std::string to avoid dangling references - refresh parent entry on rename and skip unnamed views
#4893 Async Inventory review improvements
rohvani
reviewed
Oct 30, 2025
rohvani
reviewed
Oct 30, 2025
rohvani
reviewed
Nov 6, 2025
| handleFetchComplete(request.mCategoryId, response_id); | ||
| }; | ||
|
|
||
| LL_DEBUGS("AppInit") << "Async skeleton loader requesting AIS children for " |
Member
There was a problem hiding this comment.
Should this be logged under AsyncInventory instead of AppInit?
rohvani
reviewed
Nov 6, 2025
| auto active_it = mActiveFetches.find(request_id); | ||
| if (active_it == mActiveFetches.end()) | ||
| { | ||
| LL_WARNS("AppInit") << "Async skeleton loader received unexpected completion for " << request_id << LL_ENDL; |
Member
There was a problem hiding this comment.
Should this be logged under AsyncInventory instead of AppInit?
There's a few other places here in the async loader where we aren't logging under AsyncInventory.
Not a blocker, just something I noticed while doing another review.
Contributor
Author
There was a problem hiding this comment.
Thank you, I'll double check these as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces asynchronous inventory skeleton loading via AIS to accelerate login (up to 12s faster for 100k+ item inventories) by hydrating from cache, fetching essentials on-demand, and throttling UI updates. Adds debug settings for concurrency/timeouts, fixes cache persistence/dehydration, and optimizes UI with lazy folder widget creation (O(n) parent-child mapping via caching).
Testing:
QA-only
ForceAsyncInventorySkeletontoggle (enabled by default); monitor login times/cache integrity. No breaking changes.Additional test: