Merge pull request #120 from securesecrets/price-impact-error-improve…

…ment Price impact error improvement
securesecrets · Mar 29, 2024 · def9038 · def9038
2 parents 211e3a2 + 80f593f
commit def9038
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/few-taxis-pay.md b/.changeset/few-taxis-pay.md
@@ -0,0 +1,5 @@
+---
+"@shadeprotocol/shadejs": patch
+---
+
+clarity around price impact error
diff --git a/src/lib/swap/stableswapCurve/stable.test.ts b/src/lib/swap/stableswapCurve/stable.test.ts
@@ -132,7 +132,7 @@ test('slippage calculations correct', () => {
 
   // slippage limit
   conf = getConfSmallPool();
-  expect(() => conf.swapToken0WithToken1(BigNumber(100000000))).toThrowError(/^The slippage of this trade.*/);
+  expect(() => conf.swapToken0WithToken1(BigNumber(100000000))).toThrowError(/^The price impact of this trade.*/);
 });
 
 test('py correct', () => {

diff --git a/src/lib/swap/stableswapCurve/stable.ts b/src/lib/swap/stableswapCurve/stable.ts
@@ -480,7 +480,7 @@ export class StableConfig {
       tradeDirIs0For1,
     });
     if (priceImpact.isGreaterThan(this.priceImpactLimit) || priceImpact.isLessThan(BigNumber(0))) {
-      throw Error(`The slippage of this trade is outside of the acceptable range of 0% - ${this.priceImpactLimit}%.`);
+      throw Error(`The price impact of this trade (${priceImpact.toString()}%) is outside of the acceptable range of 0% - ${this.priceImpactLimit}%.`);
     }
   }