Shade staking query interface and APY calculation for derivatives #118
Conversation
SissonJ
commented
Mar 28, 2024
SissonJ
commented
- Shade staking query interface
- APY for stkd-SCRT
- APY for dSHD
🦋 Changeset detectedLatest commit: 2d5dc78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| queryRouterCodeHash?: string, | ||
| contractAddress: string, | ||
| codeHash: string, | ||
| lcdEndpoint: string, |
There was a problem hiding this comment.
Not optional since the chain queries require it, I'll add a comment to explain
| queryRouterCodeHash?: string, | ||
| contractAddress: string, | ||
| codeHash: string, | ||
| lcdEndpoint: string, |
src/lib/apy/derivativeScrt.ts
Outdated
| * ex. for daily compounding periodRate=365 | ||
| * @param {number} apr - Annual Percentage Rate | ||
| */ | ||
| const calcAPY = (periodRate:number, apr:number):number => (1 + apr / periodRate) ** periodRate - 1; |
There was a problem hiding this comment.
let's move this function to a file location that is not derivativeScrt specific as it seems likely to be reused elsewhere.
There was a problem hiding this comment.
I meant this single function, but it looks like you moved the whole file which i was not intending in my comment
| queryRouterCodeHash?: string, | ||
| contractAddress: string, | ||
| codeHash: string, | ||
| lcdEndpoint: string, |
| // data returned from the contract in normalized form with | ||
| // 18 decimals, in addition to any decimals on the individual token |
There was a problem hiding this comment.
could you move this comment up to the const definition so it's clear what it is for at the line it is defined?
