Lend vault messages #125
Lend vault messages #125
Conversation
🦋 Changeset detectedLatest commit: ec570eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AustinWoetzel
force-pushed
the
lend-vault-messages
branch
from
89ad5ef
to
97b030f
Compare
|
note to self: squash and merge this |
src/contracts/definitions/lend.ts
Outdated
| * @param startingPage The data is paginated and returned | ||
| * for the starting page and all pages after. Use 1 to query all vaults. | ||
| */ | ||
| const msgGetVaults = (startingPage: number) => ({ |
There was a problem hiding this comment.
I'd like this to be string and have the casting happen in the services
There was a problem hiding this comment.
Also have you tried this query with a string? it could be a u128 type
There was a problem hiding this comment.
string works, this is what we do on front end.
There was a problem hiding this comment.
changed to string
src/contracts/definitions/lend.ts
Outdated
| vaultId, | ||
| }: { | ||
| borrowAmount: string, | ||
| maxBorrowFee: string, |
There was a problem hiding this comment.
Should this be optional? maxBorrowFee?:
| collateralAddress: string, | ||
| silkMaxAllowance: string, | ||
| silkAllowanceUsed: string, | ||
| maxLtv: number, |
There was a problem hiding this comment.
adding clarity in the docs
| lastUpdatedAt: Date, | ||
| }, | ||
| liquidationFee: { | ||
| discount: number, |
src/types/contracts/lend/model.ts
Outdated
|
|
||
| type BatchVaults = BatchVaultsItem[] | ||
|
|
||
| type VaultUserData = { |
There was a problem hiding this comment.
Why are we adding user data queries?
There was a problem hiding this comment.
copy paste from front end, put a note in the services layer that they are Experimental and not tested for production use. I could split them out if you think that makes sense to do.
| /** | ||
| * Parse lend vault response | ||
| */ | ||
| function parseLendVault(vault: VaultResponse, vaultVersion: VaultVersion) { |
There was a problem hiding this comment.
Can we make vaultVersion optional and have it default to v3, the most up to date version?
There was a problem hiding this comment.
Is there really no way to programatically determine the version?
There was a problem hiding this comment.
there is no way to programatically determine, unfortunately.... that would have been a great feature that should have been included when we started making new vaults.
There was a problem hiding this comment.
I'd rather not set defaults.
| // Collateral is expressed differently depending on vault type | ||
| collateral: { | ||
| total: | ||
| (vaultVersion === VaultVersion.V1 || vaultVersion === VaultVersion.V2) |
There was a problem hiding this comment.
Is there a reason that V2 is included in this check? Why did V3 get the big change?
There was a problem hiding this comment.
it's different math for the collateral display. I don't know why it was such a big change, i wish it would have been consistent.
src/contracts/services/lend.ts
Outdated
| }, | ||
| debt, | ||
| collateral_addr: collateralAddress, | ||
| is_protocol: isProtocol, |
There was a problem hiding this comment.
nit: isProtocol -> isProtocolOnly
src/contracts/services/lend.ts
Outdated
| ...prev, | ||
| [vaultId]: parseLendVault(vault, vaultVersion), | ||
| }; | ||
| }, {} as Vaults); |
There was a problem hiding this comment.
Move this type declaration to line 140 please
| */ | ||
| const parseBatchQueryVaultsInfo = ( | ||
| response: BatchQueryParsedResponse, | ||
| vaultVersions: VaultVersion[], |
There was a problem hiding this comment.
I really dislike that vaultVersions is a required argument.... we really should find a way to make it work without it
There was a problem hiding this comment.
also dislike it, but we have no choice and need to be clear about the differences between the different vaults.
Shade Lend Vault queries, tests, docs (public queries only)