-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Money market interface #161
Conversation
🦋 Changeset detectedLatest commit: 95444a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
totalPages: number, | ||
totalItems: number, | ||
data: { | ||
[token: string]: T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this type should be modified or renamed more specifically for the use case, because I know that there are going to be other types of pagination data in the pipeline (swap configs for example) that won't be keyed by a token.
.changeset/lovely-dogs-pretend.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
"@shadeprotocol/shadejs": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to patch since we aren't releasing any new feature to the public
lcdEndpoint, | ||
chainId, | ||
moneyMarketContracts, | ||
batchSize = SERVICE_BATCH_SIZE.PAIR_INFO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would just leave this empty for now so we don't accidentally forget about this and leave pair_info in as the default.
lcdEndpoint, | ||
chainId, | ||
moneyMarketContracts, | ||
batchSize = SERVICE_BATCH_SIZE.PAIR_INFO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
lcdEndpoint, | ||
chainId, | ||
moneyMarketContracts, | ||
batchSize = SERVICE_BATCH_SIZE.PAIR_INFO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done! Only a few minors.
Money market interface (#161)
No description provided.