-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve duplicate memberships, superiors/subordinates, and areas of operation #775
Conversation
@@ -76,3 +76,16 @@ def get_spreadsheet_source_field_name(cls, field_name): | |||
# If no source field name is specified, the default is usually | |||
# the spreadsheet field name with ":source" appended on | |||
return cls.get_spreadsheet_field_name(field_name) + ':source' | |||
|
|||
|
|||
class SuperlativeDateMixin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_value
seems to return an arbitrary object if there is more than one value for a complex field. This mixin adds properties to classes with start and end dates so you can retrieve the earliest start date and latest end date. This is handy for displaying information sorted by either/both dates, else the sort appears nonsensical.
@@ -1733,7 +1733,7 @@ def create_person(self, person_data): | |||
role = None | |||
else: | |||
if role_name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if role_name can have whitespace in it, seems safest to do the strip before evaluating the truthyness of role_name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
This PR resolves three bugs that manifested as duplicates in the user interface:
Connects #697, #774.
Testing Instructions