Update existing sources/access points on import, bulletproof publication date validation #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgregg
requested changes
Sep 21, 2021
|
|
||
| new_source, created = Source.objects.get_or_create(**source_info) | ||
| for prefix in ('published', 'created', 'uploaded'): |
There was a problem hiding this comment.
this timestampe handling would be good to factor out to a separate function/method.
fgregg
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the logic of the import to create or update existing access points and sources. Most of the changes here are reorganizations of existing code.
Connects #763.
Testing Instructions