chore: new rust lint #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To get rid of rust yelling at me :)
Explanation of Changes
Code change is replacing
% 2 == 0with.is_multiple_of(2). Rust yells at you now to replace the former with the more optimized latter that uses bit operations and is built in to the language. I'm not actually going to recompile and re-deploy this change, though. It makes a better/easier to read example.Figured good time to finally add the workspace fields for min rust version, authors, etc.
Also adding a
rust-toolchain.tomlsince these are binaries and I don't want to get annoyed by future rust linter updates unless we opt to update.Testing
N/A
Related PRs and Issues
N/A