Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link fixes in website docs #34

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

itsgreggreg
Copy link
Contributor

This PR fixes all the broken links in the docs on the website. This PR does not attempt to change any language unless where the link was pointing to no longer exists. This means that some of the content in support.md#initialization is outdated, some of the content in view.md is outdated, and possibly other content too.

fixes: #17

@MartinKavik
Copy link
Member

note: Once you are ready for code review, please squash commits and rebase your branch onto the current Seed's master. We are rebasing PRs onto master so we don't want to have commits like Merge branch master into 17/doc_link_fixes in our commit history. Thank you.

@itsgreggreg
Copy link
Contributor Author

Squashed and rebased and good to go for review.

@David-OConnor
Copy link
Member

Good stuff. And good to know you can put latest in the Rust docs url.

@David-OConnor David-OConnor merged commit 93ed3fe into seed-rs:master Mar 10, 2020
@itsgreggreg itsgreggreg deleted the 17/doc_link_fixes branch March 10, 2020 05:21
@MartinKavik
Copy link
Member

  • I reopened the associated issue because broken link linter isn't implemented and there will be probably more broken links in the future.
  • @David-OConnor Please rebase instead of creating merge commits.
  • latest vs fixed (Broken links #17 (comment)) - There are problems with both - fixed isn't updated but it can't be broken; latest can be easily broken but we don't need to update it for each Seed version. In ideal world, we should use fixed links and have branch for each Seed version and allow users to switch between them on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links
3 participants