Skip to content

Commit

Permalink
Upgrade kotlin-bip39-jvm to 1.0.6
Browse files Browse the repository at this point in the history
Bip39ComparisionTest was run before and after upgrading org.bitcoinj:bitcoinj-core to latest version to ensure that kotlin-bip39 is still behaving the same.

A small tweak in WordListTest was needed because WorldList constructor was made internal.
  • Loading branch information
grote committed Oct 9, 2023
1 parent aa0e82c commit 1a78bd5
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ dependencies {
implementation fileTree(include: ['*.jar'], dir: "${rootProject.rootDir}/libs/koin-android")
implementation fileTree(include: ['*.aar'], dir: "${rootProject.rootDir}/libs/koin-android")

// implementation "cash.z.ecc.android:kotlin-bip39:1.0.4"
implementation fileTree(include: ['kotlin-bip39-jvm-1.0.4.jar'], dir: "${rootProject.rootDir}/libs")
// implementation "cash.z.ecc.android:kotlin-bip39:1.0.6"
implementation fileTree(include: ['kotlin-bip39-jvm-1.0.6.jar'], dir: "${rootProject.rootDir}/libs")

/**
* Test Dependencies (do not concern the AOSP build)
Expand All @@ -153,7 +153,7 @@ dependencies {
testImplementation "org.junit.jupiter:junit-jupiter-api:$junit5_version"
testImplementation "org.junit.jupiter:junit-jupiter-params:$junit5_version"
testImplementation "io.mockk:mockk:$mockk_version"
testImplementation 'org.bitcoinj:bitcoinj-core:0.15.10'
testImplementation 'org.bitcoinj:bitcoinj-core:0.16.2'
testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:$junit5_version"
testRuntimeOnly "org.junit.vintage:junit-vintage-engine:$junit5_version"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2066,7 +2066,7 @@ class WordListTest {

@Test
fun `word list of library did not change`() {
val libWords = WordList().words
val libWords = Mnemonics.getCachedWords("en")
for (i in words.indices) {
assertEquals(words[i], libWords[i])
}
Expand Down
2 changes: 1 addition & 1 deletion libs/Android.bp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
java_import {
name: "seedvault-lib-kotlin-bip39",
jars: ["kotlin-bip39-jvm-1.0.4.jar"],
jars: ["kotlin-bip39-jvm-1.0.6.jar"],
sdk_version: "current",
}
Binary file removed libs/kotlin-bip39-jvm-1.0.4.jar
Binary file not shown.
Binary file added libs/kotlin-bip39-jvm-1.0.6.jar
Binary file not shown.

0 comments on commit 1a78bd5

Please sign in to comment.