Properly migrate existing users to new plugin setup

seedvault-app · Apr 24, 2024 · 2458263 · 2458263
1 parent e92c9c9
commit 2458263
Showing 1 changed file with 17 additions and 5 deletions.
diff --git a/app/src/main/java/com/stevesoltys/seedvault/settings/SettingsManager.kt b/app/src/main/java/com/stevesoltys/seedvault/settings/SettingsManager.kt
@@ -102,11 +102,23 @@ class SettingsManager(private val context: Context) {
     }
 
     internal val storagePluginType: StoragePluginEnum?
-        get() = prefs.getString(PREF_KEY_STORAGE_PLUGIN, StoragePluginEnum.SAF.name)?.let {
-            try {
-                StoragePluginEnum.valueOf(it)
-            } catch (e: IllegalArgumentException) {
-                null
+        get() {
+            val savedType = prefs.getString(PREF_KEY_STORAGE_PLUGIN, null)
+            return if (savedType == null) {
+                // check if this is an existing user that needs to be migrated
+                // this check could be removed after a reasonable migration time (added 2024)
+                if (prefs.getString(PREF_KEY_STORAGE_URI, null) != null) {
+                    prefs.edit()
+                        .putString(PREF_KEY_STORAGE_PLUGIN, StoragePluginEnum.SAF.name)
+                        .apply()
+                    StoragePluginEnum.SAF
+                } else null
+            } else savedType.let {
+                try {
+                    StoragePluginEnum.valueOf(it)
+                } catch (e: IllegalArgumentException) {
+                    null
+                }
             }
         }