Skip installing APKs if not allowed by policy #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirayudesai
commented
Jan 12, 2023
app/src/main/java/com/stevesoltys/seedvault/restore/install/ApkRestore.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/restore/install/ApkRestore.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/restore/install/ApkRestore.kt
Outdated
Show resolved
Hide resolved
chirayudesai
force-pushed
the
78-skipapk
branch
3 times, most recently
from
9439df0
to
d646900
Compare
chirayudesai
commented
Jan 17, 2023
app/src/test/java/com/stevesoltys/seedvault/restore/install/ApkBackupRestoreTest.kt
Outdated
Show resolved
Hide resolved
chirayudesai
commented
Jan 17, 2023
app/src/test/java/com/stevesoltys/seedvault/restore/install/ApkRestoreTest.kt
Outdated
Show resolved
Hide resolved
chirayudesai
force-pushed
the
78-skipapk
branch
from
d646900
to
4cb4894
Compare
grote
reviewed
Jan 17, 2023
app/src/test/java/com/stevesoltys/seedvault/restore/install/ApkRestoreTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/restore/install/ApkRestore.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/restore/install/ApkRestore.kt
Outdated
Show resolved
Hide resolved
chirayudesai
force-pushed
the
78-skipapk
branch
2 times, most recently
from
9ede604
to
55fafa0
Compare
chirayudesai
commented
Jan 18, 2023
app/src/test/java/com/stevesoltys/seedvault/restore/install/ApkRestoreTest.kt
Show resolved
Hide resolved
grote
previously approved these changes
Jan 23, 2023
|
Downstream tracking issue: https://gitlab.com/CalyxOS/calyxos/-/issues/1519 |
|
Still needs testing :) |
chirayudesai
force-pushed
the
78-skipapk
branch
from
55fafa0
to
5225495
Compare
t-m-w
reviewed
Apr 16, 2024
app/src/main/java/com/stevesoltys/seedvault/restore/install/InstallModule.kt
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/restore/install/ApkRestore.kt
Show resolved
Hide resolved
t-m-w
previously approved these changes
May 14, 2024
* We should not bypass the OS-wide APK install restriction. * Simply treat that as just not having the APK in the first place, since we do support that as an option. * This still lets users install apps via the store it was downloaded from, if said store is installed and allowed to install apps. * Introduce InstallRestriction to make testing easier. Co-Authored-By: Torsten Grote <[email protected]> Change-Id: Ic0a56961c9078d4dd542db5d9fc75034abb27bea
|
Rebased, one trivial conflict in tests fixed. |
|
One test failure:
|
|
that test failure happens everywhere, we don't know why. |
grote
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #78
When APK install is blocked by policy, this should treat it the same as if the APK just wasn't present, and then use the flow we already have for that ("Tap to install"), which is normally used when people turn off "APK Backup"