Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 14 - Basic updates, Android.bp #574

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Conversation

chirayudesai
Copy link
Member

@chirayudesai chirayudesai commented Oct 6, 2023

#564

SeedVault is built using two build systems

  • Android.bp, used for including in AOSP inline
  • gradle, mainly used for development, and also to create APKs to include inline

AOSP 14 is here. With this it builds and mostly works in 14. May need more changes. We'll have a temporary mismatch with gradle, but that's ok given this does work.

@chirayudesai chirayudesai mentioned this pull request Oct 6, 2023
@chirayudesai chirayudesai force-pushed the staging/android14 branch 3 times, most recently from 2b16bee to a14ec79 Compare October 6, 2023 23:39
@chirayudesai
Copy link
Member Author

Can enable "storage backup" now without crashing.

There may be more things needed for the API bump, and also in general.

A temporary alternative could be to set targetSdk to 33 in Android.bp/AndroidManifest.xml - maybe.

@chirayudesai chirayudesai force-pushed the staging/android14 branch 2 times, most recently from 0da1815 to bd898e7 Compare October 7, 2023 00:38
@chirayudesai
Copy link
Member Author

Most of these changes are gradle only. Only the perm addition is required for AOSP, so I'll split that out.

gradle/dependencies.gradle Outdated Show resolved Hide resolved
Change-Id: Ia5ebd0f3f1ccb5f9261a956f2485d60f22a5f269
* Android 14 is here!

Change-Id: Ic4249bb1d2a3ac03011f5b7608534ecd526e99c6
* Android.bp build means we get set to targetSdk 34 already

Fixes: Starting FGS with type dataSync targetSDK=34 requires permissions
See: https://developer.android.com/about/versions/14/changes/fgs-types-required#data-sync
Change-Id: I69932d778e870535522e08dff131f1bb1d128955
@chirayudesai chirayudesai changed the title [WiP] Android 14 Android 14 - Basic updates, Android.bp Oct 7, 2023
@chirayudesai chirayudesai changed the base branch from android13 to android14 October 7, 2023 19:07
@chirayudesai chirayudesai mentioned this pull request Oct 7, 2023
5 tasks
@chirayudesai chirayudesai merged commit fcdacf2 into android14 Oct 7, 2023
2 of 3 checks passed
@grote grote linked an issue Oct 10, 2023 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port to Android 14
2 participants