colors: Switch to public APIs for colors #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added comments similar to dependencies in Gradle files to keep track of source colors. Re-used colors that were the same. |
|
In theory the actions runs should show have screenshots / videos to verify some parts. |
theimpulson
force-pushed
the
publicAPIs
branch
from
ecb5962
to
ed1ca32
Compare
|
@stevesoltys any ideas why this didn't have the other actions workflows? The emulator tests. |
|
@chirayudesai Should be fixed with #580. |
|
@theimpulson could you rebase? |
grote
reviewed
Oct 10, 2023
theimpulson
force-pushed
the
publicAPIs
branch
from
ed1ca32
to
e6b9bce
Compare
Signed-off-by: Aayush Gupta <[email protected]>
chirayudesai
force-pushed
the
publicAPIs
branch
from
e6b9bce
to
0ec2dab
Compare
grote
approved these changes
Nov 28, 2023
|
Seems fine to me on both AOSP & Gradle builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches color resources to public APIs instead of system ones. This fixes colors on Gradle builds as well as Android Studio can access them as well.
Related Issues
Testing
Compile Gradle build, and check all colors look fine.