Version upgrades of included libraries and test dependencies #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bip39ComparisionTest was run before and after upgrading org.bitcoinj:bitcoinj-core to latest version to ensure that kotlin-bip39 is still behaving the same. A small tweak in WordListTest was needed because WorldList constructor was made internal.
1.11.0 is tagged, but not released to maven central, yet.
I'm happy to have the upgrade done at the same time, but shipping it in production could be a bit later to avoid any potential issues found here from blocking shipping. |
Drop this from title given they aren't needed for 14 |
Closed
5 tasks
grote
changed the title
stevesoltys
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not strictly needed for Android, but historically, we are using the opportunity when testing new Android versions in depth to also bump dependency versions. Otherwise, we'd never to it.
Note that this intentionally is not upgrading koin as the plan is to replace it with hilt rather sooner than later.
related to #564