Switch to Kotlin build scripts + version catalog #585
Conversation
stevesoltys
force-pushed
the
feature/kotlin-gradle-build-scripts
branch
2 times, most recently
from
b40f365
to
5c0e29a
Compare
stevesoltys
force-pushed
the
feature/kotlin-gradle-build-scripts
branch
from
5c0e29a
to
3a1e77b
Compare
stevesoltys
force-pushed
the
feature/kotlin-gradle-build-scripts
branch
from
b5dfb92
to
75fc00d
Compare
| # We use "strictly" to enforce the version cannot be overriden by transitive dependencies. | ||
| # We need to enforce that the versions we use are the same as AOSP to ensure compatibility. | ||
|
|
||
| # Kotlin versions |
There was a problem hiding this comment.
The comment for this got lost, https://android.googlesource.com/platform/external/kotlinc/+/refs/tags/android-14.0.0_r1/build.txt
| @@ -0,0 +1,5 @@ | |||
| [versions] | |||
| kotlin = "1.8.10" | |||
There was a problem hiding this comment.
should probably keep the comments for the various kotlin versions and why we are using this one, here.
There was a problem hiding this comment.
Added the AOSP link here. Any other comments you think would be good here let me know and will add it.
There was a problem hiding this comment.
I found the comments we had before helpful, explaining that we need to match kotlin versions of AOSP here and what Android version was using which Kotlin version, but I guess we can build this up again starting from 14.
storage/lib/build.gradle.kts
Outdated
|
|
||
| defaultConfig { | ||
| minSdk = libs.versions.minSdk.get().toInt() | ||
| targetSdk = libs.versions.targetSdk.get().toInt() |
There was a problem hiding this comment.
looks like this is deprecated, probably because we don't need to set this for libraries.
There's some other deprecation warnings (e.g. lintOptions -> lint), maybe already address them in an extra commit?
There was a problem hiding this comment.
Removed and fixed most others.
build.gradle.kts
Outdated
| buildscript { | ||
| repositories { | ||
| google() | ||
| jcenter() |
build.gradle.kts
Outdated
| } | ||
|
|
||
| subprojects { | ||
| if (path == ":app" || path == ":storage:lib") { |
There was a problem hiding this comment.
I guess we could enable this everywhere?
There was a problem hiding this comment.
Enabled for all except demo, which has a few violations.
stevesoltys
force-pushed
the
feature/e2e-test-logs
branch
3 times, most recently
from
0ef70a1
to
7bd0852
Compare
stevesoltys
force-pushed
the
feature/kotlin-gradle-build-scripts
branch
from
75fc00d
to
93e58f7
Compare
stevesoltys
force-pushed
the
feature/e2e-test-logs
branch
from
7bd0852
to
551538f
Compare
stevesoltys
force-pushed
the
feature/kotlin-gradle-build-scripts
branch
from
e64b00d
to
ba50b88
Compare
| @@ -0,0 +1,5 @@ | |||
| [versions] | |||
| kotlin = "1.8.10" | |||
There was a problem hiding this comment.
I found the comments we had before helpful, explaining that we need to match kotlin versions of AOSP here and what Android version was using which Kotlin version, but I guess we can build this up again starting from 14.
stevesoltys
force-pushed
the
feature/kotlin-gradle-build-scripts
branch
from
ba50b88
to
b131aaf
Compare
No description provided.