Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to restore storage providing app #689

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

grote
Copy link
Collaborator

@grote grote commented Jun 18, 2024

Fixes #687

@grote grote requested a review from t-m-w June 18, 2024 13:27
otherwise it gets killed during data restore which kills our restore process
@grote grote force-pushed the 687-restore-provider-kill branch from a7ec1ff to 97093ca Compare June 19, 2024 12:26
@grote grote marked this pull request as ready for review June 19, 2024 12:26
@t-m-w
Copy link
Collaborator

t-m-w commented Jun 24, 2024

Looks like this works! At the end of the restoration process, DAVx5 shows a red circle exclamation icon without an explanation (it's not the only one - maybe the handling or descriptions of failures is a larger/separate issue), but at least there's no crash of the whole process.

Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works fine for me.

@grote
Copy link
Collaborator Author

grote commented Jun 24, 2024

Thanks for testing!

@grote grote merged commit cba160b into seedvault-app:android14 Jun 24, 2024
3 checks passed
@grote grote deleted the 687-restore-provider-kill branch June 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage provider (Davx5) is killed during restoration, failing the entire process - at least with D2D
2 participants