Material3 #699
Merged
Material3 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switches look really bad right now. At best I can copy the colors from datura and design from AOSP's settingsLib but unless we have gradle builds or AOSP updates the material components library, it is going to look bad. |
theimpulson
force-pushed
the
material3
branch
2 times, most recently
from
afcffe1
to
632a08b
Compare
grote
reviewed
Jun 24, 2024
app/src/main/java/com/stevesoltys/seedvault/settings/SchedulingFragment.kt
Show resolved
Hide resolved
|
|
colors seem wrong here:
|
|
For some reason, the exclamation mark error icon isn't red anymore: In dark theme it is even worse, because dark greyish. |
theimpulson
force-pushed
the
material3
branch
2 times, most recently
from
5b0e44d
to
21efa98
Compare
Default to NoActionBar theme and use toolbar where required Signed-off-by: Aayush Gupta <[email protected]>
* Merge accent and primary color for simpler color management * Apply background color on status and navigation bar * Drop non-required colors Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Material theme seems to be not respecting the tint color in the XML. Override the colors manually to get the job done. Signed-off-by: Aayush Gupta <[email protected]>
CollapsingToolbarLayout doesn't seems to be respecting background color for some reason Signed-off-by: Aayush Gupta <[email protected]>
|
The only issue I can see right now is MD3 switches having wrong color in dark theme. |
Signed-off-by: Aayush Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sumary
This PR migrates Seedvault to use Material3.
Issues
Test
Everything passes locally