Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask on first run if user wants restore #717

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Ask on first run if user wants restore #717

merged 2 commits into from
Aug 21, 2024

Conversation

grote
Copy link
Collaborator

@grote grote commented Aug 15, 2024 •
edited
Loading

This moves checking for set recovery code and storage location from SettingsActivity to SettingsFragment. In SettingsActivity we now check for first start and if detected, we show a new FirstStartFragment where the user can decide to restore an old backup or to set-up backups.

Part of #671

Fixes #571

t-m-w
t-m-w requested changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new screen ignores the Back button, regardless of whether it's launched via Settings or via a launcher icon. Can that be fixed?

@grote
Copy link
Collaborator Author

grote commented Aug 15, 2024

thanks. fixed back navigation.

t-m-w
t-m-w previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works!

@grote grote dismissed t-m-w’s stale review August 15, 2024 21:28

The merge-base changed after approval.

theimpulson
theimpulson approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t-m-w
t-m-w approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works as expected for me.

@grote grote merged commit 9923286 into seedvault-app:android14 Aug 21, 2024
1 check passed
@grote grote deleted the ask-if-restore branch August 21, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theimpulson theimpulson theimpulson approved these changes

@t-m-w t-m-w t-m-w approved these changes

@stevesoltys stevesoltys Awaiting requested review from stevesoltys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to restore work profile
3 participants
@grote @t-m-w @theimpulson