-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't re-install apps that are already installed and disable auto-restore #719
Don't re-install apps that are already installed and disable auto-restore #719
Conversation
a6fff47
to
750c4b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works! I have a couple of thoughts, but I'm not sure if they even ought to be addressed:
- Apps that were already installed do not show app icons, just the generic icon. This looks a little odd alongside apps that were not already installed, as if maybe something went wrong.
- Apps that were already installed appear so abruptly - especially if all the apps were already installed - that, as above, it looks like maybe something went wrong.
The apps do have green checkmarks, which indicate everything should be fine, but I could see how a user might get a mixed message from the observed behavior.
Ideally, it could be communicated somehow that the app was already installed, but I don't think it's necessarily a blocker.
I think at least the first point should get addressed. However, I can't reproduce it. See this video for how things look for me: Screen_recording_20240816_094845.mp4There's a bit of abruptness when all the apps suddenly show up, but doesn't look bad to me. |
750c4b5
to
4bf1265
Compare
I added two commits related to disabling auto-restore during install to avoid restoring the same data twice for affected apps. |
4bf1265
to
570850a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a user-facing perspective (no code review or adb, just what I can see happening), this all appears to work fine to me!
I think this was all true. My backup was from a production build of CalyxOS, for which no stable version currently includes the change to include icons in the backups (should be in 5.10.x which is almost stable). So, it did not have icons or names stored. I made another backup with the latest upstream code along with these changes, and the described/shown issue is not present. Icons and names are shown. |
This doesn't re-install apps that are already installed at the same or a newer version. Also, if auto-restore is enabled during install, it disables it and re-enables it when install is complete.
Part of #671