Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retries: don't upload metadata three times #736

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix retries: don't upload metadata three times #736

merged 1 commit into from
Sep 5, 2024

Conversation

grote
Copy link
Collaborator

@grote grote commented Sep 5, 2024

No description provided.

@grote grote added this to the 3.x milestone Sep 5, 2024
t-m-w
t-m-w approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested yet, but code changes look good to me. (I accidentally manifested this same kind of problem in a script just the other day, forgetting to break out of a retry loop...)

@grote grote merged commit b8602fd into seedvault-app:android14 Sep 5, 2024
1 check passed
@grote grote deleted the fix-retry branch September 5, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-m-w t-m-w t-m-w approved these changes

@chirayudesai chirayudesai Awaiting requested review from chirayudesai

@theimpulson theimpulson Awaiting requested review from theimpulson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@grote @t-m-w