Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support edge to edge #747

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Support edge to edge #747

merged 1 commit into from
Sep 20, 2024

Conversation

theimpulson
Copy link
Collaborator

No description provided.

Signed-off-by: Aayush Gupta <[email protected]>
@grote
Copy link
Collaborator

grote commented Sep 18, 2024

Thanks, looks good. Didn't test yet. But why not also apply this to the other activities?

@grote
Copy link
Collaborator

grote commented Sep 18, 2024

I am also curious, why you didn't use enableEdgeToEdge() https://developer.android.com/develop/ui/views/layout/edge-to-edge#enable-edge-to-edge-display

@theimpulson
Copy link
Collaborator Author

I am also curious, why you didn't use enableEdgeToEdge() https://developer.android.com/develop/ui/views/layout/edge-to-edge#enable-edge-to-edge-display

This is called by default now if an app is targeting Android 15, so we don't need to call it manually

@theimpulson
Copy link
Collaborator Author

Thanks, looks good. Didn't test yet. But why not also apply this to the other activities?

All activities seem to extend BackupActivity directly or indirectly except the one I have applied manually.

@grote
Copy link
Collaborator

grote commented Sep 19, 2024

Alright, and did you visit all those activities and checked that they look alright? I don't have an Android 15 test device, yet, so I can't check myself.

@theimpulson
Copy link
Collaborator Author

Alright, and did you visit all those activities and checked that they look alright? I don't have an Android 15 test device, yet, so I can't check myself.

Seems fine to me

@grote
Copy link
Collaborator

grote commented Sep 20, 2024

Alright, I'll ping you with specific issues if I notice them on 15.

@grote grote merged commit f2aec3f into seedvault-app:android15 Sep 20, 2024
1 check passed
@grote
Copy link
Collaborator

grote commented Sep 23, 2024

Had a chance to test this on 15. See where the screen at the top cuts things off:

Screenshot_20240923_115629

We are losing lots of vertical space her.e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants