Skip to content

Conversation

@0xSysR3ll
Copy link
Contributor

Description

This PR introduces an optional API key field in the webhook settings, allowing users to authenticate to the webhook using the X-API-Key header.

Screenshot (if UI-related)

image

To-Dos

  • Disclosed any use of AI (see our policy)
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

This PR introduces an optional API key field in the webhook settings, allowing users to authenticate to the webhook using the `X-API-Key` header.

Signed-off-by: 0xsysr3ll <[email protected]>
@M0NsTeRRR
Copy link
Member

Should we rework this feature and allow users to configure the headers they need? That way, it would cover all future feature requests regarding this.

@0xSysR3ll
Copy link
Contributor Author

0xSysR3ll commented Oct 6, 2025

Should we rework this feature and allow users to configure the headers they need? That way, it would cover all future feature requests regarding this.

Since the X-API-Key is a de facto standard, I thought it would be better to keep it like this. But yeah, maybe we could implement a custom headers feature; allowing to put literally everything we want, like you said.

@gauthier-th
Copy link
Member

Should we rework this feature and allow users to configure the headers they need? That way, it would cover all future feature requests regarding this.

Since the X-API-Key is a de facto standard, I thought it would be better to keep it like this. But yeah, maybe we could implement a custom headers feature; allowing to put literally everything we want, like you said.

Yeah, it's probably better, some 3rd party apps use other ways to authenticate. That's also what I implemented in *arr.

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@0xSysR3ll
Copy link
Contributor Author

That's also what I implemented in *arr.

Oh, I will check this out !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Cannot merge due to merge conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants