-
-
Notifications
You must be signed in to change notification settings - Fork 475
docs: add migration guide #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
This guide is low value for users with existing Jellyseerr and Overserr instances. It essentially tells them to scratch whatever they had previously in e.g. docker compose and replace it with whatever is in the general getting started guide which is geared towards new users. |
3d0a373 to
bdbccfb
Compare
|
|
I understand its in draft, but you requested a review. So thats why I wanted to give some feedback. I just dont find it helpful overall. It literally says to replace the whole compose file with new one. But there is a good chance that the user is running different services in a single compose file. What should they do then? I dont think majority of users would need this much hand holding to migrate. Showing an example of an old docker compose file and then the new one with specific changes that were made highlighted would be better. |
Signed-off-by: Ludovic Ortega <[email protected]>
Co-authored-by: Joe Harrison <[email protected]>
Co-authored-by: Gauthier <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Co-authored-by: Gauthier <[email protected]>
41c8f24 to
a140077
Compare
Signed-off-by: Ludovic Ortega <[email protected]>
gauthier-th
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
add migration guide