Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizely v2 compatibility #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Optimizely v2 compatibility #12

wants to merge 4 commits into from

Conversation

chillpop
Copy link

@chillpop chillpop commented Oct 1, 2018

This PR adds compatibility with OptimizelySDK v2.

Optimizely no longer posts notifications using NSNotificationCenter. They now use OPTLYNotificationCenter which is a property on the OPTLYClient, not a singleton.

As a consequence, Optimizely must be fully initialized before Segment so that there is an instance of OPTLYClient for the SEGOptimizelyXIntegration to access when it is created.

Carl Hill-Popper added 4 commits October 1, 2018 11:49
No longer a dependency for OptimizelySDK
Disabled these suggested warnings for less warning noise:
- CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF
- CLANG_WARN_STRICT_PROTOTYPES
- GCC_WARN_UNDECLARED_SELECTOR
Optimizely no longer posts notifications using NSNotificationCenter.  They now use OPTLYNotificationCenter which is a property on the OPTLYClient, not a singleton.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant