-
Notifications
You must be signed in to change notification settings - Fork 284
STRATCONN-6008 - [Twilio Messaging] - FB Messenger support #3204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (62.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
==========================================
- Coverage 79.62% 79.61% -0.02%
==========================================
Files 1177 1177
Lines 21703 21718 +15
Branches 4216 4225 +9
==========================================
+ Hits 17282 17291 +9
- Misses 3679 3684 +5
- Partials 742 743 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Facebook Messenger support to the Twilio Messaging destination action. The changes enable sending messages through Facebook Messenger by introducing new channel options and required fields for Messenger-specific identifiers.
Key changes:
- Added Facebook Messenger as a supported channel option with feature flag control
- Introduced new required fields for Messenger user ID and Facebook page ID
- Updated field validation logic to handle Messenger-specific requirements
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
utils.ts | Added Messenger channel handling and Facebook page ID validation logic |
index.ts | Added dynamic channel field configuration |
generated-types.ts | Updated field names for Messenger user ID and Facebook page ID |
fields.ts | Made channel dynamic and added conditional requirements for Messenger fields |
dynamic-fields.ts | Added feature flag-controlled channel options and Messenger sender type |
constants.ts | Updated sender type constant from generic to Facebook-specific naming |
index.test.ts | Added comprehensive tests for Messenger functionality and error cases |
dynamic-fields.test.ts | Added tests for dynamic channel field behavior with feature flags |
{ | ||
fieldKey: 'channels', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fieldKey 'channels' should be 'channel' (singular) to match the actual field name defined in the schema.
{ | |
fieldKey: 'channels', | |
fieldKey: 'channel', |
Copilot uses AI. Check for mistakes.
{ | ||
fieldKey: 'channels', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fieldKey 'channels' should be 'channel' (singular) to match the actual field name defined in the schema.
{ | |
fieldKey: 'channels', | |
fieldKey: 'channel', |
Copilot uses AI. Check for mistakes.
]) | ||
}) | ||
|
||
it('channel for Facebook Messenger channel option should hidden when flag enabled', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test description contains a grammatical error. It should read 'should be hidden when flag is disabled' or 'should be hidden when flag is not enabled'.
it('channel for Facebook Messenger channel option should hidden when flag enabled', async () => { | |
it('channel for Facebook Messenger channel option should be hidden when flag is not enabled', async () => { |
Copilot uses AI. Check for mistakes.
packages/destination-actions/src/destinations/twilio-messaging/sendMessage/fields.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/twilio-messaging/sendMessage/utils.ts
Show resolved
Hide resolved
Just left couple of comments. Also, it seems like codecov/patch is failing because test coverage isn't sufficient enough. pls see if we can increase test coverage |
PR deployed |
PR to add FB Messenger support to Twilio Messaging Destination
Testing
Unit tests added
Testing in production with feature flag