Skip to content

Conversation

nk1107
Copy link
Contributor

@nk1107 nk1107 commented Aug 28, 2025

JIRA - https://twilio-engineering.atlassian.net/browse/STRATCONN-6015?atlOrigin=eyJpIjoiMzg0OGZlYWY3MDhjNDE5YWJlNjc1NDA1MjBhMjQ3YjYiLCJwIjoiaiJ9

This change adds a validation logic to validate the IAM role for the liveramp audienceEnteredS3 action. This is done using HEAD request to the S3 bucket with the IAM credentials in the mappings.
Number of batch events processed by liveramp in 1 day
image-20250829-044028

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
image image
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.61%. Comparing base (67a677e) to head (fa3c140).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nations/liveramp-audiences/audienceEnteredS3/s3.ts 68.42% 4 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (73.91%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3209      +/-   ##
==========================================
- Coverage   79.62%   79.61%   -0.01%     
==========================================
  Files        1177     1177              
  Lines       21703    21722      +19     
  Branches     4220     4228       +8     
==========================================
+ Hits        17282    17295      +13     
- Misses       3679     3683       +4     
- Partials      742      744       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nk1107 nk1107 marked this pull request as ready for review September 2, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants