StackAdapt Audience Destination: Fix profile deletion query #3215
Conversation
| label: "Advertiser ID", | ||
| description: "The StackAdapt advertiser ID to add the profile to. The value in this field field can also be overridden at the Action level via the Action field of the same name.", | ||
| type: 'string', | ||
| required: true, |
There was a problem hiding this comment.
Should be required:false.
| description: "The StackAdapt advertiser ID to add the profile to. The value in this field field can also be overridden at the Action level via the Action field of the same name.", | ||
| type: 'string', | ||
| required: true, | ||
| disabledInputMethods: ['literal', 'variable', 'function', 'freeform', 'enrichment'], |
There was a problem hiding this comment.
No need for this line. Customers can't map data from payloads anyway so you can delete this line.
| const userId = payload.userId | ||
| const formattedExternalIds = `["${userId}"]` | ||
| const syncId = sha256hash(String(userId)) | ||
| const advertiserId = settings.advertiser_id | ||
| if(!advertiserId) { | ||
| throw new InvalidAuthenticationError("Advertiser value must be provided in either the main Settings Advertiser field or at the Action level Advertiser field.") |
There was a problem hiding this comment.
| throw new InvalidAuthenticationError("Advertiser value must be provided in either the main Settings Advertiser field or at the Action level Advertiser field.") | |
| throw new InvalidAuthenticationError("To delete a user, the Advertiser field in Settings should be populated.") |
|
Hi @joe-ayoub-segment, thanks for your comments. Is there a way to use a dynamic dropdown instead of input box for advertiserID in under Settings? |
|
We will not enable onDelete if we can't have the dropdown for advertiserIds in a single place that can be referenced for both |
|
It's not in use by clients at the moment. The traffic is from our internal testing. |
Ah OK if no customers are using it, we can just keep the advertiserIds field in Settings / authentication, and then delete the advertiserIds in the Mappings UI. |
Yes, we can surely do that but more importantly we want to keep the UI intuitive for clients. I tried to have the |
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.