Telemetry Metrics #214

MichaelGHSeg · 2024-03-22T18:54:54Z

No description provided.

codecov · 2024-03-22T18:59:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.10%. Comparing base (79cfb46) to head (21398d6).
Report is 1 commits behind head on main.

❗ Current head 21398d6 differs from pull request most recent head edeb8c8. Consider uploading reports for the commit edeb8c8 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##               main     #214       +/-   ##
=============================================
- Coverage     78.65%   46.10%   -32.55%     
+ Complexity      502       14      -488     
=============================================
  Files            78        8       -70     
  Lines          6588      874     -5714     
  Branches        833       85      -748     
=============================================
- Hits           5182      403     -4779     
+ Misses          735      437      -298     
+ Partials        671       34      -637

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/src/main/java/com/segment/analytics/kotlin/core/Telemetry.kt

core/src/main/java/com/segment/analytics/kotlin/core/platform/Mediator.kt

core/src/main/java/com/segment/analytics/kotlin/core/Telemetry.kt

core/src/main/java/com/segment/analytics/kotlin/core/Settings.kt

core/src/main/java/com/segment/analytics/kotlin/core/Telemetry.kt

…to MichaelGHSeg/Telemetry

wenxi-zeng

overall in good shape. just 4 things needs to be addressed before merged:

possible concurrent issue on the telemetry queue
consolidate 3 error reporting methods to 1 for simplicity
better to have a lookup table for telemetry queue
make Telemetry a Subscriber of Sovran

core/src/main/java/com/segment/analytics/kotlin/core/Analytics.kt

core/src/main/java/com/segment/analytics/kotlin/core/Settings.kt

core/src/main/java/com/segment/analytics/kotlin/core/Telemetry.kt

…nalytics-kotlin into MichaelGHSeg/Telemetry

core/src/main/java/com/segment/analytics/kotlin/core/Analytics.kt

wenxi-zeng · 2024-05-02T18:16:06Z

core/src/test/kotlin/com/segment/analytics/kotlin/core/TelemetryTest.kt

        assertEquals(0, TelemetryQueueSize())
        assertEquals(0,errors.size)
    }

    @Test
    fun `Test increment with no tags`() {
        Telemetry.start()
-        Telemetry.increment(Telemetry.INVOKE_METRIC, emptyMap())
+        Telemetry.increment(Telemetry.INVOKE_METRIC) { it.clear() }


no need to clear. can just leave it with empty brackets. or make the tagBuilder nullable, so you don't have to pass anything

It was in the test so I just figured I'd make it explicit about what it was expected to do, rather than minimize code. Just say the word if you'd rather it go away.

…ated bugs

MichaelGHSeg added 6 commits February 27, 2024 22:40

First pass at adding telemetry

f8463b8

Fixing metric name

5ab0c18

More tags, singleton, other improvements

8f13b6d

Fixing missing values

c5170b3

Many features added and bugs fixed. Currently does not send log data.

1adbbba

A few improvements around enable

ffde914

Adding empty header to missing parameter of HTTPExceptions in tests

f1c1d73

wenxi-zeng reviewed Mar 22, 2024

View reviewed changes