Skip to content

fix: #142 raw literal with backslashes becomes "unescaped" #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: #142 raw literal with backslashes becomes "unescaped" #143

wants to merge 3 commits into from
+3 −3

Conversation

dim0xff
Copy link

@dim0xff dim0xff commented Aug 11, 2024 •
edited
Loading

fix #142

ccoVeille
ccoVeille reviewed Aug 11, 2024
View reviewed changes
Copy link

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no tests updated, wasn't any?

@dim0xff
Copy link
Author

dim0xff commented Aug 11, 2024 •
edited
Loading

I see no tests updated, wasn't any?

@ccoVeille I added test to _fixtures/struct_tags.go and test expectation to _fixtures/struct_tags__exp.go

Fixtures are being tested via shortener_test.go

@ccoVeille
Copy link

Oh that's right. I expected the tests to be in a _test.go file

@mgabeler-lee-6rs
Copy link

I believe this will also fix #161 which is a dupe of #142

@mgabeler-lee-6rs mgabeler-lee-6rs mentioned this pull request Mar 24, 2025
Open
@amanbolat
Copy link

Hi there,
Is there anything missing in this PR that requires contribution, or it can be merged?

@landonalder
Copy link

This is also a problem for us that I just discovered today. If this could be merged, that would be amazing @mckern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ccoVeille ccoVeille ccoVeille approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: raw literal with backslashes becomes "unescaped"
5 participants
@dim0xff @ccoVeille @mgabeler-lee-6rs @amanbolat @landonalder